clarify argument splitting in 'rocq makefile' - #22322
Open
RalfJung wants to merge 1 commit into
Open
Conversation
coqbot-app
Bot
added
the
needs: full CI
RalfJung
commented
Jul 29, 2026
| But note, that single-quotes in a ``_RocqProject`` file are only special | ||
| characters if they appear in the string following ``-arg``. And on their own | ||
| they don't quote spaces. For example ``-arg 'foo bar'`` in ``_RocqProject`` is | ||
| equivalent to ``-arg foo "bar'"`` (in ``_RocqProject`` notation). ``-arg "'foo |
Contributor
Author
There was a problem hiding this comment.
This part here is still confusing me, or maybe it is wrong. Somehow the first ', the one before foo, is apparently getting lost?
RalfJung
force-pushed
the
rocq-makefile-arg-splitting
branch
from
July 29, 2026 10:28
c544bdb to
8efa6dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs say that
-arg "-w all"passes the argument-w alltorocq compile, but that's not quite correct -- when stated like that, I would interpret this as meaning that a single argument,"-w all", is passed torocq compile. What actually happens is that two arguments,"-w" "all", are passed. So this adjusts the docs to clarify that.What is still missing is a description of how to pass arbitrary arguments. For instance if I wanted to pass
arg' argas a single argument, as in the shell invocationrocq compile "arg\' arg", I do not know how I would do that. Lucky enough this does not usually seem to be necessary...